refactor(@angular/build): introduce internal generic test runner API in unit-test builder#30938
Merged
Merged
Conversation
…in unit-test builder Refactors the unit-test builder to introduce a generic `TestRunner` API. This change decouples the main builder logic from the specifics of individual test runners like Karma and Vitest. The new API consists of two main parts: - `TestRunner`: A declarative definition of a test runner, including its name and hooks for creating an executor and getting build options. - `TestExecutor`: A stateful object that manages a test execution session. The Karma and Vitest runners have been refactored to implement this new API. The Karma runner is now marked as `isStandalone: true` to indicate that it manages its own build process. The Vitest runner now uses the `getBuildOptions` hook to provide its build configuration to the main builder. This refactoring makes the unit-test builder more extensible, allowing for new test runners to be added more easily in the future. It also improves the separation of concerns within the builder, making the code easier to understand and maintain.
clydin
added
the
action: review
alan-agius4
approved these changes
Aug 18, 2025
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the unit-test builder to introduce an internal generic
TestRunnerAPI. This change decouples the main builder logic from the specifics of individual test runners like Karma and Vitest.The new API consists of two main parts:
TestRunner: A declarative definition of a test runner, including its name and hooks for creating an executor and getting build options.TestExecutor: A stateful object that manages a test execution session.The Karma and Vitest runners have been refactored to implement this new API. The Karma runner is now marked as
isStandalone: trueto indicate that it manages its own build process. The Vitest runner now uses thegetBuildOptionshook to provide its build configuration to the main builder.